lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Adds Ferneyhough hairpins to LilyPond. (issue 7615043)


From: janek . lilypond
Subject: Re: Adds Ferneyhough hairpins to LilyPond. (issue 7615043)
Date: Tue, 12 Mar 2013 23:02:31 +0000

Nice hairpins!

Janek


https://codereview.appspot.com/7615043/diff/23001/input/regression/ferneyhough-hairpins.ly
File input/regression/ferneyhough-hairpins.ly (right):

https://codereview.appspot.com/7615043/diff/23001/input/regression/ferneyhough-hairpins.ly#newcode4
input/regression/ferneyhough-hairpins.ly:4: texidoc = "LilyPond creates
hairpins found in Ferneyhough scores.
Please be more specific - a user might not know what Ferneyhough scores
look like.
For example, add "There are two variants of Ferneyhough hairpins: one is
horizontal for its whole length with short vertical line at the end that
is louder, and another one is similar to ordinary hairpin except that
its width doesn't change evenly - it's narrower with a wide opening at
the end"

https://codereview.appspot.com/7615043/diff/23001/scm/output-lib.scm
File scm/output-lib.scm (right):

https://codereview.appspot.com/7615043/diff/23001/scm/output-lib.scm#newcode1030
scm/output-lib.scm:1030: and draws the stencil based on its coordinates.
I really like this description.  It's so good that i immediately knew
how the output will look like before i compiled it - congrats!

https://codereview.appspot.com/7615043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]