lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Removes '-signs in vectors - follow-up (issue 7834043)


From: janek . lilypond
Subject: Re: Removes '-signs in vectors - follow-up (issue 7834043)
Date: Sun, 17 Mar 2013 16:24:16 +0000

This patch needs a review from someone more knowledgeable in
docs/snippets than me.


https://codereview.appspot.com/7834043/diff/2001/Documentation/snippets/new/applying-note-head-styles-depending-on-the-step-of-the-scale.ly
File
Documentation/snippets/new/applying-note-head-styles-depending-on-the-step-of-the-scale.ly
(right):

https://codereview.appspot.com/7834043/diff/2001/Documentation/snippets/new/applying-note-head-styles-depending-on-the-step-of-the-scale.ly#newcode1
Documentation/snippets/new/applying-note-head-styles-depending-on-the-step-of-the-scale.ly:1:
\version "2.17.15"
I'm no expert on documentation and snippets, but this change (and some
other ones, too) look suspicious.

https://codereview.appspot.com/7834043/diff/2001/Documentation/snippets/preventing-final-mark-from-removing-final-tuplet.ly
File
Documentation/snippets/preventing-final-mark-from-removing-final-tuplet.ly
(right):

https://codereview.appspot.com/7834043/diff/2001/Documentation/snippets/preventing-final-mark-from-removing-final-tuplet.ly#newcode27
Documentation/snippets/preventing-final-mark-from-removing-final-tuplet.ly:27:

this looks suspicious to my eyes (again, i'm no expert on snippets and
docs)

https://codereview.appspot.com/7834043/diff/2001/Documentation/snippets/separating-key-cancellations-from-key-signature-changes.ly
File
Documentation/snippets/separating-key-cancellations-from-key-signature-changes.ly
(right):

https://codereview.appspot.com/7834043/diff/2001/Documentation/snippets/separating-key-cancellations-from-key-signature-changes.ly#newcode47
Documentation/snippets/separating-key-cancellations-from-key-signature-changes.ly:47:
} % begin verbatim
...and this one, too.

https://codereview.appspot.com/7834043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]