[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: X-aligning on Y-parent - ?? advice needed
From: |
Janek Warchoł |
Subject: |
Re: X-aligning on Y-parent - ?? advice needed |
Date: |
Tue, 9 Apr 2013 01:50:51 +0200 |
hi,
2013/4/5 Janek Warchoł <address@hidden>:
> 2013/4/5 Neil Puttock <address@hidden>:
>> On 5 April 2013 17:47, Janek Warchoł <address@hidden> wrote:
>>
>>> Regardless of it being a spanner, i've tried to find where
>>> MultiMeasureRestText's (and MultiMeasureRestNumber's) Xparent is set,
>>> but without sucsess. I thought that maybe it happens in line 240 of
>>> paper-column-engraver, but apparently not.
>>
>> Spanner:set_bound ()
>
> Ah! Thanks a lot, that set me back on track.
> From my tests it seems that there is no need to reset X-parent of
> MMRtexts, MMRnumbers and PercentRepeatCounters in this place - if we
> let them continue to be what they were set to using previous patch
> (i.e. MMRs/PercentRepeat), everything seems to be fine. What do you
> think about it? (a draft patch is attached - my tests say that it
> doesn't change anything in regtests).
after some more thinking i believe that this is a reasonable way to
go. I've added this as a first commit (cce7fefdbc1) on branch
dev/janek-alignment, and it's also visible in
https://codereview.appspot.com/7768043/ (although that issue is pretty
messy).
best,
Janek