lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Adds padding around extender of line-spanners. (issue 8819043)


From: k-ohara5a5a
Subject: Re: Adds padding around extender of line-spanners. (issue 8819043)
Date: Sat, 20 Apr 2013 05:06:08 +0000


https://codereview.appspot.com/8819043/diff/5001/lily/line-spanner.cc
File lily/line-spanner.cc (right):

https://codereview.appspot.com/8819043/diff/5001/lily/line-spanner.cc#newcode371
lily/line-spanner.cc:371: // actual stencil bounds may be different
The actual stencil bounds are (inf , -inf) if someone sets style=none
When I try this on input/regression/dynamics-alignment-no-line.ly the
while loop in add_grobs_of_one_priority() takes forever.

https://codereview.appspot.com/8819043/diff/5001/lily/line-spanner.cc#newcode377
lily/line-spanner.cc:377: Real new_left_y = minmax (-d, extremity,
line_left[Y_AXIS] + d * skyline_spanner_padding);
The smaller of the extent of the cresc.--- and the line padded by
skyline_spanner_padding.  Is that what you want?

https://codereview.appspot.com/8819043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]