[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: is changing OctavateEight to ClefModifier appropriate for 2.18?
From: |
Janek Warchoł |
Subject: |
Re: is changing OctavateEight to ClefModifier appropriate for 2.18? |
Date: |
Sun, 21 Apr 2013 21:58:22 +0200 |
2013/4/21 David Kastrup <address@hidden>:
> Janek Warchoł <address@hidden> writes:
>
>> http://code.google.com/p/lilypond/issues/detail?id=3309
>> https://codereview.appspot.com/8614045
>>
>> This had passed countdown (with 0 reviews). I'm not sure if it's
>> "stable enough" to be included in 2.18 - should i push it or set it's
>> status to waiting?
>
> I haven't reviewed the patch as such. If it is just a rename, you
> should be able to verify using "git grep" that no occurences of the old
> name remain so I don't see that as a problematic change.
I did that. What worries me is that i've done this before, and
apparently i missed some occurences then. The rename seems not to be
so trivial, that's why i'm not sure. I'd feel more comfortable
pushing this if there was any review.
Janek