Re: Beams: be transparent if the first stem is transparent; issue 2866 (issue 9239046)

[k-ohara5a5a]

Reviewers: dak,

Message:
On 2013/05/15 07:45:21, dak wrote:


https://codereview.appspot.com/9239046/diff/1/scm/music-functions.scm#oldcode1947
> scm/music-functions.scm:1947: (map (lambda (st)
> That's a case for for-each, not map.

Probably so, but I think changing it with this unrelated change
complicates the history more than it would improve the clarity.

Description:
Beams: be transparent if the first stem is transparent; issue 2866

so that \hideNotes does not hide automatic beams that could have,
but did not, start on a hidden note.

Please review this at https://codereview.appspot.com/9239046/

Affected files:
  M ly/property-init.ly
  M scm/define-grobs.scm
  M scm/music-functions.scm


Index: ly/property-init.ly
diff --git a/ly/property-init.ly b/ly/property-init.ly
index  
1c97c04fabf096b6f496cfe9a1ad521fdd59b255..b7962ecf2c15c9a6be9786039d12c69f7fd5eb37  
100644
--- a/ly/property-init.ly
+++ b/ly/property-init.ly
@@ -265,14 +265,12 @@ hideNotes = {
   \override NoteHead.no-ledgers = ##t
   \override Stem.transparent = ##t
   \override Flag.transparent = ##t
-  \override Beam.transparent = ##t
   \override Accidental.transparent = ##t
   \override Rest.transparent = ##t
   \override TabNoteHead.transparent = ##t
 }
 unHideNotes = {
   \revert Accidental.transparent
-  \revert Beam.transparent
   \revert Stem.transparent
   \revert Flag.transparent
   \revert NoteHead.transparent
Index: scm/define-grobs.scm
diff --git a/scm/define-grobs.scm b/scm/define-grobs.scm
index  
1b1df433c659a35c0695e8ba5820079e5a161684..0826d15203e9da4bc4658d530d7a4bf5dbb19c8b  
100644
--- a/scm/define-grobs.scm
+++ b/scm/define-grobs.scm
@@ -410,6 +410,8 @@
        (positions . ,beam::place-broken-parts-individually)
        (springs-and-rods . ,ly:beam::calc-springs-and-rods)
        (X-positions . ,ly:beam::calc-x-positions)
+        (transparent . ,(grob::inherit-parent-property
+                         X 'transparent))

        ;; this is a hack to set stem lengths, if positions is set.
        (quantized-positions . ,ly:beam::set-stem-lengths)
Index: scm/music-functions.scm
diff --git a/scm/music-functions.scm b/scm/music-functions.scm
index  
16e035bcbbe1ea71b1afc0ae6869d238f7675837..b08ecb7fab13958552ee86cf640cd128b6f04862  
100644
--- a/scm/music-functions.scm
+++ b/scm/music-functions.scm
@@ -1945,7 +1945,7 @@ base onto the following musical context."
                 (blot (ly:output-def-lookup layout 'blot-diameter)))
            ; Hide spanned stems
            (map (lambda (st)
-                  (set! (ly:grob-property st 'transparent) #t))
+                  (set! (ly:grob-property st 'stencil) #f))
              stems)
            ; Draw a nice looking stem with rounded corners
            (ly:round-filled-box (ly:grob-extent root root X) yextent blot))