[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Small corrections to the scheme reformatting patch. (issue 9964049)
|
From: |
dak |
|
Subject: |
Re: Small corrections to the scheme reformatting patch. (issue 9964049) |
|
Date: |
Sun, 09 Jun 2013 12:48:14 +0000 |
On 2013/06/09 12:11:22, marc wrote:
https://codereview.appspot.com/9964049/diff/2001/scm/define-context-properties.scm
File scm/define-context-properties.scm (right):
https://codereview.appspot.com/9964049/diff/2001/scm/define-context-properties.scm#newcode524
scm/define-context-properties.scm:524: @}
On 2013/06/09 08:35:27, dak wrote:
> This won't work.
It did work. If you run fixscm.sh on the changed file,
it clearly says:
(No changes need to be saved)
at the end of the terminal output.
But if there is something that may be improved (either on the
indentaion script or the source file), then I need some more
information rather than "this won't work" ;-)
You should base your work likely on
<URL:http://codereview.appspot.com/10078046>. In that patch, I worked
on the source files until
(setq open-paren-in-column-0-is-defun-start nil)
would no longer generate different output when calling fixscm scm/*.scm
It would be more reliable to repeat that comparison with different
indentation settings (to make sure that one did not overlook already
properly indented material that did not get reindented because
mistakenly assumed to be inside of a string), but since this was
starting from the state before running fixscm for the first time, it's
likely pretty complete.
https://codereview.appspot.com/9964049/