lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

markup: give the padding functions effect in skyline spacing; issue 3255


From: lemzwerg
Subject: markup: give the padding functions effect in skyline spacing; issue 3255 (issue 9295044)
Date: Sun, 09 Jun 2013 19:37:27 +0000

The code looks reasonable, at least to me :-)  Thanks for working on
this.


https://codereview.appspot.com/9295044/diff/11001/input/regression/text-script-vertical-skylines.ly
File input/regression/text-script-vertical-skylines.ly (right):

https://codereview.appspot.com/9295044/diff/11001/input/regression/text-script-vertical-skylines.ly#newcode6
input/regression/text-script-vertical-skylines.ly:6: spacing reservation
of a stencil, while @code{with-dimensions} completely
This is hard to understand IMHO.  What about

  @code{pad-around} computes the (smallest) bounding box of a stencil
and pads this box by the given amount.  @code{with-dimensions}
completely...

https://codereview.appspot.com/9295044/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]