[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Uses single algorithm for side-position spacing. (issue 6827072)
|
From: |
k-ohara5a5a |
|
Subject: |
Re: Uses single algorithm for side-position spacing. (issue 6827072) |
|
Date: |
Mon, 19 Aug 2013 20:31:53 +0000 |
I'm away for a few days.
https://codereview.appspot.com/6827072/diff/38003/lily/pointer-group-interface.cc
File lily/pointer-group-interface.cc (right):
https://codereview.appspot.com/6827072/diff/38003/lily/pointer-group-interface.cc#newcode74
lily/pointer-group-interface.cc:74: // computation time when skylines
are calculated.
Probably we should not recursively add elements numerous times.
https://codereview.appspot.com/6827072/diff/38003/lily/side-position-interface.cc
File lily/side-position-interface.cc (right):
https://codereview.appspot.com/6827072/diff/38003/lily/side-position-interface.cc#newcode57
lily/side-position-interface.cc:57:
Side_position_interface::recursive_add_support (Grob *me, Grob *e)
Probably this is for stacking scripts alongside a note, so that if the
furthest can slip around the inner script, it still avoids the note and
flag. It should not add elements multiple times.
https://codereview.appspot.com/6827072/diff/38003/lily/stencil-integral.cc
File lily/stencil-integral.cc (right):
https://codereview.appspot.com/6827072/diff/38003/lily/stencil-integral.cc#newcode975
lily/stencil-integral.cc:975: : me->extent (me, X_AXIS);
maybe_pure_extent
https://codereview.appspot.com/6827072/