lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: more comments (issue 13051044)


From: frederic . bron . 1995
Subject: Re: more comments (issue 13051044)
Date: Tue, 20 Aug 2013 19:51:54 +0000


https://codereview.appspot.com/13051044/diff/1/lily/misc.cc
File lily/misc.cc (left):

https://codereview.appspot.com/13051044/diff/1/lily/misc.cc#oldcode116
lily/misc.cc:116: }
it is just a modified inverse function so that f(0)=1 instead of +inf
and f(threshold)=0 instead of f(+inf)=0.
epsilon is used to control the speed at which the function decreases:
the smaller epsilon, the quicker the function decreases. When epsilon =
+inf, the function is linear.
Note that we could add:
assert(threshold>0.);
assert(epsilon>0.);

https://codereview.appspot.com/13051044/diff/1/lily/tie-configuration.cc
File lily/tie-configuration.cc (right):

https://codereview.appspot.com/13051044/diff/1/lily/tie-configuration.cc#newcode128
lily/tie-configuration.cc:128: *
changing 'string' to 'const string&' where it makes sense is something I
would be good at.

https://codereview.appspot.com/13051044/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]