|
| From: | janek . lilypond |
| Subject: | Re: Add documentation for the music function \alterBroken to the NR. (issue 15060044) |
| Date: | Sat, 19 Oct 2013 17:07:55 +0000 |
LGTM except for one comment.
https://codereview.appspot.com/15060044/diff/350001/Documentation/notation/changing-defaults.itely
File Documentation/notation/changing-defaults.itely (right):
https://codereview.appspot.com/15060044/diff/350001/Documentation/notation/changing-defaults.itely#newcode4362
Documentation/notation/changing-defaults.itely:4362: \alterBroken
damping #'(10 1) Beam
I think this is not a very good example, as it's not immediately obvious
what the code did (the change can be overloked).
I think it would be better to use something like this:
\relative c'' {
r2
\alterBroken thickness #'(1 10) Slur
c8( d e f
\break
g8 f e d) r2
}
https://codereview.appspot.com/15060044/
| [Prev in Thread] | Current Thread | [Next in Thread] |