Re: there are actually four commits: (issue 14640043)

[k-ohara5a5a]

None of the examples show \set completionFactorUnit = n/m  actually
helping.  Is there an example where this property is more useful than a
boolean switch?

By contrast, the earlier patch <http://codereview.appspot.com/14633043>
using completionLongestScaled to divide long- versus short notes, made
the examples in the bug-reports work by default, and included
documentation.

Either this patch or the earlier one could be augmented by allowing
users to set 'completionFactor' to specify the output scale-factor that
the engraver should use for 'long' notes, for the case Pál brought up
\scaleDurations 2/3 { a1.*9 }


https://codereview.appspot.com/14640043/diff/3001/input/regression/completion-rest.ly
File input/regression/completion-rest.ly (right):

https://codereview.appspot.com/14640043/diff/3001/input/regression/completion-rest.ly#newcode9
input/regression/completion-rest.ly:9: just scale the total duration
taken.
This claims that {r1*2}
would be split into {r2*2 | r2*2}
but that is not what the code does.

https://codereview.appspot.com/14640043/diff/3001/input/regression/completion-rest.ly#newcode25
input/regression/completion-rest.ly:25: r4 ^"r4" r8*4 ^"r8*4" r8*8
^"r8*8"
The un-split r8*4 makes the test hard to interpret.

https://codereview.appspot.com/14640043/diff/3001/scm/define-context-properties.scm
File scm/define-context-properties.scm (right):

https://codereview.appspot.com/14640043/diff/3001/scm/define-context-properties.scm#newcode238
scm/define-context-properties.scm:238: rather than scaled notes.
Does this actually work?

\scaleDurations 2/1 {
  \set completionFactorUnit = 2/1
  g4 a2 b4 }

It seems that the engraver would see { g4*2 a2*2 b4*2 }
and split a1*2 as a 'long' note into { g4*2 a2~ | a2 b4*2 }

Maybe only integer-greater-than-one multiples should count?

https://codereview.appspot.com/14640043/diff/3001/scm/define-context-properties.scm#newcode243
scm/define-context-properties.scm:243: interpreting whole measure
multiples as long notes.
I do not see why this is true.  There can be tuplets that scale music by
*3/4 in 3/4 time.
{\time 3/4
\tuplet 4/3 {c4 d e f} \tuplet 4/3 {g2 a1 b2} \tuplet 2/3 {c4 c,}}

https://codereview.appspot.com/14640043/