Re: Looks for prebroken pieces of dead items in the pure relevant function. (issue 18090043)

[k-ohara5a5a]

On 2013/10/30 08:09:53, mike7 wrote:
> On Oct 30, 2013, at 8:32 AM, mailto:address@hidden wrote:

> > I do not understand the Todo: comment; nothing should have been
suicided
> > at this stage.

> The original clef is suicided in the handle_prebroken_dependencies
function,
> which is the same place that the new begin and end of line grobs are
created
> (see break-substitution.cc).

> Conceptually, I don’t like the idea that a suicided grob contains
useful
> information.

I see now.
It seems that !is_live() means that we are sure the Grob will never be
printed, yet we need to keep the data structure around for some other
reason.  You might put your name on the "Todo" comment so people know
the point of view is from somebody other that the original author of the
handle_prebroken_dependencies() function.

The patch looks good.

https://codereview.appspot.com/18090043/