|
| From: | dak |
| Subject: | Re: optimal-page-breaking: signed/unsigned bug; issue 1553 (issue 22750045) |
| Date: | Wed, 20 Nov 2013 08:53:24 +0000 |
https://codereview.appspot.com/22750045/diff/1/lily/optimal-page-breaking.cc File lily/optimal-page-breaking.cc (right): https://codereview.appspot.com/22750045/diff/1/lily/optimal-page-breaking.cc#newcode120 lily/optimal-page-breaking.cc:120: for (vsize sys_count = ideal_sys_count + 1; --sys_count >= (vsize) min_sys_count;) This was labelled as signed/unsigned bug. If min_sys_count would happen to be negative, this loop will never get run at all since (vsize)-1 is a very large positive number. That does not seem correct. https://codereview.appspot.com/22750045/
| [Prev in Thread] | Current Thread | [Next in Thread] |