Re: Metafont code cleanup (issue 38530043)

[Janek Warchoł]

2013/12/9  <address@hidden>:
> i have not looked at the code, but small nit: I think you could leave
> the new subdirectory for another time. 5 files (and only accidentals)
> does not fix anything, and rather adds to the confusion.

Indeed.  I'll remove the subdir, but keep the split.


2013/12/9  <address@hidden>:
> also, for reviewing, you should do the file reorganization and the code
> reorganization in different changes.

2013/12/9  <address@hidden>:
> It's also a good idea to move files and change files in different
> commits since git gets worse at tracking moves/renames the more changes
> happen in a single commit.  While you can give git special command line
> options to make it more thorough, it's a pain to do this for the various
> tools and workflows somehow trying to reconstruct history.

You're right, i apologize.  Had i known right from the start what
exactly i was going to do, i'd try to keep this separation
consistently.  But since i had no idea what the end result was going
to be (due to the code being messy), i didn't organize it well and it
got mixed.

However, if you don't mind, i'd prefer to leave it as is - i have
_already_ spent about 4 hours cleaning up and rebasing commits to make
them somewhat ordered for review, and i'm quite tired.

Anyway, thanks for the review!
Janek