[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Cleanup of ugly MI and SOL shaped noteheads (issue 45160043)
|
From: |
lemzwerg |
|
Subject: |
Re: Cleanup of ugly MI and SOL shaped noteheads (issue 45160043) |
|
Date: |
Tue, 24 Dec 2013 00:57:53 +0000 |
LGTM, codewise. Since I don't use Sacred Harp notation, I can't give
further comments w.r.t. usefulness or correctness.
https://codereview.appspot.com/45160043/diff/1/Documentation/contributor/source-code.itexi
File Documentation/contributor/source-code.itexi (left):
https://codereview.appspot.com/45160043/diff/1/Documentation/contributor/source-code.itexi#oldcode1387
Documentation/contributor/source-code.itexi:1387: First you will see a
terminal editor where you can edit the
This file's patch obviously doesn't belong to the MF changes...
https://codereview.appspot.com/45160043/diff/1/mf/feta-noteheads.mf
File mf/feta-noteheads.mf (right):
https://codereview.appspot.com/45160043/diff/1/mf/feta-noteheads.mf#newcode1450
mf/feta-noteheads.mf:1450: undraw_inside_ellipse (2.5 - puff_up_factor /
3.0, 31, 0.707, 3.5 stafflinethickness#);
Please stay in the 80-char-per-line limit.
https://codereview.appspot.com/45160043/