|
| From: | dak |
| Subject: | Gives empty heights and widths to stencil-less accidentals. (issue 45070044) |
| Date: | Wed, 25 Dec 2013 22:31:38 +0000 |
https://codereview.appspot.com/45070044/diff/1/lily/accidental.cc File lily/accidental.cc (right): https://codereview.appspot.com/45070044/diff/1/lily/accidental.cc#newcode65 lily/accidental.cc:65: return sten_p != SCM_EOL && sten_p != SCM_BOOL_F Please avoid adding more C++ value comparisons of SCM values than we have already. This should rather read return !(scm_is_null (sten_p) || scm_is_false (sten_p)) https://codereview.appspot.com/45070044/diff/1/lily/accidental.cc#newcode77 lily/accidental.cc:77: return sten_p != SCM_EOL && sten_p != SCM_BOOL_F Same here. https://codereview.appspot.com/45070044/diff/1/lily/accidental.cc#newcode138 lily/accidental.cc:138: if (sten_p != SCM_EOL && sten_p != SCM_BOOL_F Same here. https://codereview.appspot.com/45070044/
| [Prev in Thread] | Current Thread | [Next in Thread] |