Re: Where did the Staff lines come from?

[David Kastrup]

James <address@hidden> writes:

> Hello,
>
> With regard to the output of:
>
> http://lilypond.org/doc/v2.16/Documentation/notation/predefined-fretboard-diagrams
>
> (and also this is reflected in the PDF docs)
>
> There are no 'Staff' lines present.

Yes, this is issue 3290.  The Staff lines are absent due to a _change_
in the definitions of FretBoard introduced in 2.15.42, as stated in
<URL:http://code.google.com/p/lilypond/issues/detail?id=3290#c2>.

The code _always_ has been designed to display an extra staff.  The
representation in the 2.16 documentation is by _accident_ and has two
consequences:
a) the staff is missing and instead its notes end up in the FretBoard
b) the FretBoard is confused by the note repetitions and does not find
   the predefined chords

> Did something change between 2.16 and now; or rather, was this intentional?
>
> The only commit I can see that touches these files (apart from a
> convert.ly) is
>
> --snip--
> commit 236963781bc8cefaeb4e59b30e5e17fefafe0634
> Author: David Kastrup <address@hidden>
> Date:   Wed Apr 3 17:30:25 2013 +0200
>
>     Issue 3290: Appendix 4, Predefined fretboard diagram: wrong chords
> are displayed
>
> --snip--
>
> and this seems to change a \context \XXX to a \new \XXX
>
> So I am puzzled.
>
> I think they look better without the staff.

They never were intended to be displayed without additional Staff.  The
2.16 version is purely accidental.

I agree that the staff does not seem to be overly helpful.  It should be
straightforward and obvious how to remove it once you understand that
the 2.16 version did not remove it by design but rather clobbered it by
a rather weird accident in relation with a redefinition elsewhere.

-- 
David Kastrup