lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: CG: Update of Patchy instructions (issue 112280043 by address@hidden


From: pkx166h
Subject: Re: CG: Update of Patchy instructions (issue 112280043 by address@hidden)
Date: Tue, 22 Jul 2014 05:45:54 +0000

Thanks Julien


https://codereview.appspot.com/112280043/diff/20001/Documentation/contributor/administration.itexi
File Documentation/contributor/administration.itexi (right):

https://codereview.appspot.com/112280043/diff/20001/Documentation/contributor/administration.itexi#newcode161
Documentation/contributor/administration.itexi:161: knowledge of of
compiling LilyPond and its documentation along with
On 2014/07/21 18:30:32, Julien Rioux wrote:
"of of"

Done.

https://codereview.appspot.com/112280043/diff/20001/Documentation/contributor/administration.itexi#newcode172
Documentation/contributor/administration.itexi:172: requires some human
intervention in order to to visually check for any
On 2014/07/21 18:30:32, Julien Rioux wrote:
"to to"

Done.

https://codereview.appspot.com/112280043/diff/20001/Documentation/contributor/administration.itexi#newcode178
Documentation/contributor/administration.itexi:178: compile, including
building all the LilyPond documentation, finally
On 2014/07/21 18:30:32, Julien Rioux wrote:
The script makes sure that the new HEAD compiles, it does not attempt
to compile
every individual commit.

Done.

https://codereview.appspot.com/112280043/diff/20001/Documentation/contributor/administration.itexi#newcode238
Documentation/contributor/administration.itexi:238: Commit access
@emph{is} required to test patches, but a valid login
On 2014/07/21 18:30:32, Julien Rioux wrote:
"to test patches" -> "to test and push new commits"

Done.

https://codereview.appspot.com/112280043/diff/20001/Documentation/contributor/administration.itexi#newcode256
Documentation/contributor/administration.itexi:256: of the
@file{patches/} directory to your @var{PATH}.
On 2014/07/21 18:30:32, Julien Rioux wrote:
Would be useful to give the exact command line to clone the repo.

Done.

https://codereview.appspot.com/112280043/diff/20001/Documentation/contributor/administration.itexi#newcode430
Documentation/contributor/administration.itexi:430: The script can also
be run using a @emph{single} tracker issue number as
On 2014/07/21 18:30:31, Julien Rioux wrote:
You can have multiple arguments, each an issue number.

Done.

https://codereview.appspot.com/112280043/diff/20001/Documentation/contributor/administration.itexi#newcode525
Documentation/contributor/administration.itexi:525: @unnumberedsubsubsec
Checking the regression test results
On 2014/07/21 18:30:32, Julien Rioux wrote:
OK, I made it this far.

:)

Thanks. I have made some other alts after some re-reading myself

https://codereview.appspot.com/112280043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]