[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Replace internal_get_property with get_property where possible (issu
Re: Replace internal_get_property with get_property where possible (issue 137760043 by address@hidden)
Tue, 02 Sep 2014 13:45:44 +0000
So I went through a review after all and found a few niggles that seem
worth fixing. Probably does not require a full countdown and stuff, but
another patchy run might be warranted in order to avoid typos.
File lily/grob.cc (right):
lily/grob.cc:470: SCM min_ext = get_property (min_ext_name);
This one is bad since it breaks memoization. Either leave it alone or
do (properly formatted)
SCM min_ext = a == X_AXIS ? get_property ("minimum-X-extent") :
File lily/self-alignment-interface.cc (right):
lily/self-alignment-interface.cc:54: SCM align (me->get_property (sym));
lily/self-alignment-interface.cc:125: ? me->get_property
Here you do it properly!
File lily/span-bar-engraver.cc (right):
lily/span-bar-engraver.cc:85: SCM vis = bars_->get_property
This causes the symbol to be memoized three times in a row. However,
only the first time the code is being run, so I'd say never mind. The
readability should be worth it.