[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Limit looping in Grob::common_refpoint (issue 4079) (issue 134600043

From: dak
Subject: Re: Limit looping in Grob::common_refpoint (issue 4079) (issue 134600043 by address@hidden)
Date: Sun, 07 Sep 2014 06:20:59 +0000

I don't like it.  The maximum range of a variable is an arbitrary value
and this "loop avoidance" will not do us much good on a 64-bit

If this is a real concern, we should be either using a tortoise/hare
algorithm here in order to bomb out on circular references.

Or, much preferable, we should catch any such cases where the circular
reference is established.  This can only happen when an existing grob
already established as a parent of some other grob gets its parent
pointed to another existing grob.

Since it is much too late by the time Grob::common_refpoint is called to
figure out the culprit in the circular refpoint chain, that's close to
useless for debugging.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]