[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: compiler warnings

From: David Kastrup
Subject: Re: compiler warnings
Date: Sat, 04 Oct 2014 09:12:00 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux)

Werner LEMBERG <address@hidden> writes:

>> [...] it may be feasible to remove the line
>>     if (Super::print_smob != 0)
>> in lily/include/smobs.hh.  Can you check whether this solves your
>> problem or whether warnings for other functions remain?
> Other warnings remain.  I've applied the following patch to make
> compilation silent again.  No idea whether it's the correct thing...

It isn't.  free_smob and equal_p can be set to 0 and scm_set_smob_free
and scm_set_smob_equalp are not documented to be able to deal with that.

As I said: I'll be doing this in the way it was done with mark_smob.  It
will still be comparing two constants after template instantiation as
far as the compiler is concerned, but maybe it will stop complaining
(the mark_smob situation is slightly different, mark_smob being a
non-static member function now).

As you can see by the different gcc-4.8 behavior, this behavior with
regard to constant-but-depending-on-template-parameters was considered a
nuisance by others as well.

I'll do the respective change in the next 15 minutes.  At least I don't
need to create an issue for it myself any more.

David Kastrup

reply via email to

[Prev in Thread] Current Thread [Next in Thread]