[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Compact Chord Symbols Patch

From: Richard Shann
Subject: Re: Compact Chord Symbols Patch
Date: Tue, 07 Oct 2014 14:24:49 +0100

On Tue, 2014-10-07 at 12:53 +0100, James wrote:
> On 07/10/14 09:08, Richard Shann wrote:
> > On Mon, 2014-10-06 at 20:06 +0100, James wrote:
> >> Richard,
> >>
> > [..]
> >>> Richard
> >> I have created
> >>
> >>
> >>
> >> I'll help shepherd this patch through via the standard review process
> >> for this.
> > Thank you very much. I thought I would follow the instructions for
> > contributing to LilyPond starting from the top at as
> > I know how useful it is for a fresh pair of eyes to look over stuff like
> > this. This lead me to the step after creating a patch where it suggested
> > "if you have a mentor email the patch", but didn't say what one was. So
> > I improvised at this point and emailed the mailing list. I would have
> > liked to run the regression tests at that stage, but I think I ran out
> > of step-by-step instructions.
> > Reading over the documentation you quote it seems that you do have
> > contributors with the limited permission to create branches, but I
> > didn't immediately see how to register for that...
> >
> Probably here
Well this seems to be a rather general access - it warns the user not to
push to master but to staging - perhaps I was wrong thinking you had
another tier of access...

> I think we could improve the notes in the contributor's Guide generally. 

I hasten to say that what you have created is very good, I was able to
get to the submitting a patch stage without any serious problems.

> Having had to help three or four people over the last few months with a 
> patch or two, I get how the instructions are probably rather confusing 
> if not intimidating.
> I'll take a look and see what I can come up with.
> The structure of the Contributor's Guide is much 'looser' (shall we say) 
> than the manuals on how to use LilyPond. That's not to say it is 
> inaccurate, but that perhaps we could condense some of it down or 
> organize more logically certain aspects.
> Anyway, I haven't yet done anything with the Patch simply because I was 
> waiting on if it was really a snippet
Well, I certainly tried to do this without attacking the core code
itself, but I'd love it if there were some point of entry (a scheme
engraver?) that would allow chord symbols to be drawn by a user
generated routine (this is everything, including bass inversions).
>  than something that we want to add 
> into the core code. I am not a 'developer' as such (I don't write code - 
> just Doc and manage patches) so don't have any real knowledge of these 
> things.

Thank you very much


reply via email to

[Prev in Thread] Current Thread [Next in Thread]