Re: Doc: NR section 3.5.x MIDI file creation tidy up (issue 120480043 by address@hidden)

[pkx166h]

Thanks for the input as always.

Still one question remains (see thread below)


https://codereview.appspot.com/120480043/diff/180001/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):

https://codereview.appspot.com/120480043/diff/180001/Documentation/notation/input.itely#newcode2702
Documentation/notation/input.itely:2702: (#10) for drums.  Each channel
is allocated for each staff, so a score
On 2014/10/03 21:23:30, Trevor Daniels wrote:
> Staves are assigned to channels in sequence, so a score ...

Done.

https://codereview.appspot.com/120480043/diff/180001/Documentation/notation/input.itely#newcode2703
Documentation/notation/input.itely:2703: that contains more than fifteen
staves will result in the extra staffs
On 2014/10/03 21:23:31, Trevor Daniels wrote:
> staffs -> staves

Done.

https://codereview.appspot.com/120480043/diff/180001/Documentation/notation/input.itely#newcode2705
Documentation/notation/input.itely:2705: problem if the sharing staffs
have conflicting, channel-based, MIDI
On 2014/10/03 21:23:31, Trevor Daniels wrote:
> staves

Done.

https://codereview.appspot.com/120480043/diff/180001/Documentation/notation/input.itely#newcode2872
Documentation/notation/input.itely:2872: A full list of supported items
can be found in the script itself.  See
On 2014/10/03 21:23:30, Trevor Daniels wrote:
> The list you've placed in the script is not correct.

See my response to the comment you made in the script.

https://codereview.appspot.com/120480043/diff/180001/Documentation/notation/input.itely#newcode2889
Documentation/notation/input.itely:2889: A MIDI player that supports
pitch bend will be needed for Microtones.
On 2014/10/03 21:23:30, Trevor Daniels wrote:
> This is nothing to do with articulate.ly

Moved to first @knownissues section.

https://codereview.appspot.com/120480043/diff/180001/Documentation/notation/input.itely#newcode2892
Documentation/notation/input.itely:2892: accent, marcato and portato.
On 2014/10/03 21:23:31, Trevor Daniels wrote:
> These have nothing to do with articulate.ly

Moved to first @knownissues section

https://codereview.appspot.com/120480043/diff/180001/Documentation/notation/input.itely#newcode2894
Documentation/notation/input.itely:2894: Items that are not supported by
the @file{articulate} script:
On 2014/10/03 21:23:30, Trevor Daniels wrote:
> Items that are not reflected in MIDI output, even with the
@file{articulate}
> script.

Done.

https://codereview.appspot.com/120480043/diff/180001/Documentation/notation/input.itely#newcode2898
Documentation/notation/input.itely:2898: @item Tempo changes entered as
annotations without tempo markings.
On 2014/10/04 16:20:50, ht wrote:
> "tempo markings" should possibly be "metronome marks" (NR 1.2.3).

Done.

https://codereview.appspot.com/120480043/diff/180001/Documentation/notation/input.itely#newcode2901
Documentation/notation/input.itely:2901: @item Tremolos entered with
@address@hidden:address@hidden
On 2014/10/04 16:20:50, ht wrote:
> It appears that articulate.ly actually supports also these tremolos
(by
> unfolding them) since

<http://git.savannah.gnu.org/gitweb/?p=lilypond.git;a=commit;h=51146a320837b3d2f673c8ce0493e33038babc18>.

Thanks. I have therefore removed this @item.

https://codereview.appspot.com/120480043/diff/180001/Documentation/notation/input.itely#newcode2912
Documentation/notation/input.itely:2912: of dynamic markings and the
relative volume of different instruments.
On 2014/10/04 16:20:50, ht wrote:
> I'd consider moving text from the end of this section to expand the
> introduction:

>     Dynamic marks translate automatically into volume levels in the
available
>     MIDI volume range whereas crescendi and decrescendi vary the volume
>     linearly between their two extremes.  It is possible to control the
relative
>     volume of dynamic markings, and the overall volume levels of
different
>     instruments.

Done. This has now been added as you wrote it and that last para at the
end of the section has been removed.


> Also, if the goal is to give a complete list about what LilyPond does
to MIDI
> volume automatically, the new default behavior of some articulations
(issue
> 3664) is relevant also here:

>     Also, the articulations \accent, \marcato, \staccatissimo and
\staccato
>     increase the MIDI volume of the note to which they are attached (in
music
>     not processed using the articulate.ly script).

These two last entries are related.

I've taken the information that was added in the changes.tely when this
enhancement was documented, and added it to the 'Dynamic Marks in MIDI'
section below (with appropriate TexInfo formatting).

Also Trevor Daniels commented about this indirectly in the changes I
made to comments in the articulate.ly script itself.

So the 'list' of what is supported in LP for MIDI without articulate.ly
would be:

--

% Pitches.
% Microtones.  Needs a MIDI player that supports pitch bends.
% Chords entered as chord names.
% Rhythms entered as note durations, including tuplets.
% Tremolos entered without @address@hidden:address@hidden
% Ties.
% Dynamic marks.
% Crescendi, decrescendi over multiple notes.
% Tempo changes entered with a tempo marking.
% Lyrics.
% Simple articulations: staccato, staccatissimo, accent, marcato, and
portato.

However, it seems to me that we should be listing what is NOT supported
by LilyPond (or doesn't work [as expected]) rather than what does.

That should be a much easier list to maintain right?

https://codereview.appspot.com/120480043/diff/180001/Documentation/notation/input.itely#newcode3108
Documentation/notation/input.itely:3108: @rinternals{Dynamic_performer}.
On 2014/10/04 16:20:50, ht wrote:
> This paragraph can be removed if the information is moved to the
beginning of
> the subsection about dynamics.


Done.

https://codereview.appspot.com/120480043/diff/180001/ly/articulate.ly
File ly/articulate.ly (right):

https://codereview.appspot.com/120480043/diff/180001/ly/articulate.ly#newcode46
ly/articulate.ly:46: % Rallentando, accelerando, ritard and 'a tempo'.
On 2014/10/03 21:23:31, Trevor Daniels wrote:
> This list is misleading.  You've merged the list of items supported in
LilyPond
> without articulate.ly with the few added by articulate.ly, which are
just the
> last three.

Thanks, Heikke also made that same comment - albeit in a different way
(i.e. it was now missing from the main documentation).

See related comment to that as I have a general question regarding this
'supported' list.

https://codereview.appspot.com/120480043/