|
| From: | nine . fierce . ballads |
| Subject: | Re: Issue 4212: fix out-of-bounds index in division_maior() (issue 189420043 by address@hidden) |
| Date: | Fri, 02 Jan 2015 15:44:30 +0000 |
On 2015/01/02 14:36:34, dak wrote:
The case I was worried about was (line_pos.begin () < it - 1) This expression is undefined if it == line_pos.begin () since
line_pos.begin ()
- 1 is undefined, being before the start of the array.
Two lines up there is assert (line_pos.begin () < it), so it looks OK. https://codereview.appspot.com/189420043/
| [Prev in Thread] | Current Thread | [Next in Thread] |