lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Function to display the rhythmic location of a grob (issue 197690044


From: paulwmorris
Subject: Re: Function to display the rhythmic location of a grob (issue 197690044 by address@hidden)
Date: Sun, 22 Feb 2015 03:01:04 +0000

LGTM, except for a couple minor things.  Thanks for working on these
scheme functions.


https://codereview.appspot.com/197690044/diff/20001/scm/output-lib.scm
File scm/output-lib.scm (right):

https://codereview.appspot.com/197690044/diff/20001/scm/output-lib.scm#newcode30
scm/output-lib.scm:30: "Return the rhythmic position of grob @var{g} as
a list.  The
Do you mean @var{grob} ?  That would be more in line with other
functions in this file.

https://codereview.appspot.com/197690044/diff/20001/scm/output-lib.scm#newcode42
scm/output-lib.scm:42: (list when rl))
Instead of this let block I'd probably just do:

(list (ly:grob-property col 'when)
  (ly:grob-property col 'rhythmic-location))

But either way is fine with me.

https://codereview.appspot.com/197690044/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]