[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Updated patch for issue 155 (issue 230860044 by address@hidden)

From: Carl . D . Sorensen
Subject: Re: Updated patch for issue 155 (issue 230860044 by address@hidden)
Date: Tue, 21 Apr 2015 18:46:38 +0000
File scm/define-grob-properties.scm (right):
scm/define-grob-properties.scm:777: (parenthesis-friends ,list? "A lisy
of symbols.  Any parenthesis
On 2015/04/19 19:32:29, Keith wrote:
"A list of Grob types, as symbols.  When parentheses enclose a Grob
that has
'parenthesis-friends, the parentheses widen to include any child Grobs
with type
among 'parethesis-friends."

File scm/output-lib.scm (right):
scm/output-lib.scm:908: (define-public (parentheses-item::pure-y-extent
grob start end)
On 2015/04/19 19:32:29, Keith wrote:
I do not see why this function is necessary, but it looks correct.

There is a distinction between pure-y-extent and y-extent for objects
vertical position or height might change depending on where the

Maybe it was formerly necessary for the accidental on the second note
of a tie,
which might disappear, but we let those accidentals have a simple
height now.

The only need I could see for pure-y-extent here, would be to estimate
horizontal space for the parentheses around an accent outside a slur
or beam.

So is it best to remove the code, since we don't have a regtest that
exercises it?

I think that if it turns out we need a pure-y-extent we'll know it
because of a cyclic dependency when someone tries to use \parenthesize,
and then we can reinstate the code and have a regtest for it.

Do you agree?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]