lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Add stencil-flip function (issue 235090043 by address@hidden)


From: lemzwerg
Subject: Re: Add stencil-flip function (issue 235090043 by address@hidden)
Date: Tue, 05 May 2015 03:53:05 +0000

LGTM.


https://codereview.appspot.com/235090043/diff/1/input/regression/stencil-scale.ly
File input/regression/stencil-scale.ly (right):

https://codereview.appspot.com/235090043/diff/1/input/regression/stencil-scale.ly#newcode8
input/regression/stencil-scale.ly:8: its bounding box.)"
Please use two spaces after a period that ends a sentence.

https://codereview.appspot.com/235090043/diff/1/scm/stencil.scm
File scm/stencil.scm (right):

https://codereview.appspot.com/235090043/diff/1/scm/stencil.scm#newcode667
scm/stencil.scm:667: @var{axis} is 0 for X-axis, 1 for Y-axis."
Can you somehow add the words `horizontally' and `vertically'?
Additionally, I think it helps to tell the reader where the mirroring
axis is positioned.

https://codereview.appspot.com/235090043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]