|
| From: | dak |
| Subject: | Re: Part_combine_iterator: treat child iterators as a set (issue 240020043 by address@hidden) |
| Date: | Fri, 22 May 2015 07:41:43 +0000 |
Sorry for the previous empty review: somehow my comment in it got lost. https://codereview.appspot.com/240020043/diff/20001/lily/part-combine-iterator.cc File lily/part-combine-iterator.cc (right): https://codereview.appspot.com/240020043/diff/20001/lily/part-combine-iterator.cc#newcode111 lily/part-combine-iterator.cc:111: iterators_[i]->quit (); You don't check the iterator pointers before using them here. Is that change intentional? https://codereview.appspot.com/240020043/
| [Prev in Thread] | Current Thread | [Next in Thread] |