Re: Docs: clean up after \relative conversion (issue 239250043 by address@hidden)

[dak]

https://codereview.appspot.com/239250043/diff/20001/Documentation/learning/common-notation.itely
File Documentation/learning/common-notation.itely (left):

https://codereview.appspot.com/239250043/diff/20001/Documentation/learning/common-notation.itely#oldcode1184
Documentation/learning/common-notation.itely:1184: \partial 4
Ok, looks like \partial has not been caught by my patterns.  I can try
changing the patterns, reverting, rebasing, etc.  It will not be just
the learning manual.

https://codereview.appspot.com/239250043/diff/20001/Documentation/learning/common-notation.itely
File Documentation/learning/common-notation.itely (right):

https://codereview.appspot.com/239250043/diff/20001/Documentation/learning/common-notation.itely#newcode1348
Documentation/learning/common-notation.itely:1348: tripletA = \relative
{ \tuplet 3/2 { c'8 e g } }
Oh wow.  That was one ugly puppy of an example.  Looks like the first
note was tweaked until the net effect was "octave-neutral" and then the
octave for \relative was changed accordingly.  Actually a good example
of just _why_ \relative should be applied per variable rather than just
once.

Tracing the source through various manual reorganizations appears to
implicate

commit 498805dc8fdddb5b321a0dcf404a068b58cdae74
Author: Graham Percival <address@hidden>
Date:   Sat Nov 24 17:20:33 2007 -0800

    Small update to tutorial.

Good eye.

https://codereview.appspot.com/239250043/diff/20001/Documentation/learning/common-notation.itely#newcode1514
Documentation/learning/common-notation.itely:1514: will not be part of
the relative music:
not be part -> not affect the octaves

https://codereview.appspot.com/239250043/diff/20001/Documentation/learning/common-notation.itely#newcode1518
Documentation/learning/common-notation.itely:1518: c'4 \fixed c { f''
g'' } c |
Oh.  No idea why this wasn't converted automatically.

https://codereview.appspot.com/239250043/diff/20001/Documentation/learning/fundamental.itely
File Documentation/learning/fundamental.itely (right):

https://codereview.appspot.com/239250043/diff/20001/Documentation/learning/fundamental.itely#newcode762
Documentation/learning/fundamental.itely:762: \relative @{ noteA << <
noteB noteC > \\ noteD >> noteE @}
Well, those examples don't have a detectable "first pitch" for the
script, so yeah: needs fixing up.

https://codereview.appspot.com/239250043/diff/20001/Documentation/learning/fundamental.itely#newcode847
Documentation/learning/fundamental.itely:847: {  % Voice one
Probably the comment which the script does not catch.  Hard to do in
general I think.

https://codereview.appspot.com/239250043/diff/20001/Documentation/learning/fundamental.itely#newcode1013
Documentation/learning/fundamental.itely:1013: \voiceOne
Here the \voiceXxx commands.  I think I can add them to the script but
it's sort of diminuishing returns.

https://codereview.appspot.com/239250043/diff/20001/Documentation/learning/fundamental.itely#newcode1207
Documentation/learning/fundamental.itely:1207: \autoBeamOff
Huh.  So many "harmless" commands to take care off.  Probably also just
a single command.

https://codereview.appspot.com/239250043/diff/20001/Documentation/learning/fundamental.itely#newcode1313
Documentation/learning/fundamental.itely:1313: TenorMusic = \relative {
e4 | g4. g8 c4.   b8 | a8 b c d e4 }
These were \relative c  { formatted to line up with \relative c' {.  It
was probably less ugly in the script to keep the extra space.  Makes
more things line up.

https://codereview.appspot.com/239250043/diff/20001/Documentation/learning/fundamental.itely#newcode1729
Documentation/learning/fundamental.itely:1729: \set Staff.instrumentName
= #"Soprano"
Ok, that's the kind of complexity I don't want to parse automatically.

The script had about 90% coverage or so and working over Learning
manually to make it consistent makes sense.  I think we can live with
incomplete coverage elsewhere.

https://codereview.appspot.com/239250043/diff/20001/Documentation/learning/tweaks.itely
File Documentation/learning/tweaks.itely (right):

https://codereview.appspot.com/239250043/diff/20001/Documentation/learning/tweaks.itely#newcode4190
Documentation/learning/tweaks.itely:4190: a'4.\mpdolce d8
cis4--\glissando a |
Actually, I find all those

\relative c'' { a ... ->  \relative { a' ...

conversions an improvement.  But then I'm probably not the most avid
\relative user anyway.

https://codereview.appspot.com/239250043/diff/20001/Documentation/notation/pitches.itely
File Documentation/notation/pitches.itely (right):

https://codereview.appspot.com/239250043/diff/20001/Documentation/notation/pitches.itely#newcode303
Documentation/notation/pitches.itely:303: @code{\relative} is
interpreted just the same as
This change does not make sense, actually.  \relative f needs to stay
here or the sentence becomes pointless.

https://codereview.appspot.com/239250043/diff/20001/Documentation/notation/simultaneous.itely
File Documentation/notation/simultaneous.itely (right):

https://codereview.appspot.com/239250043/diff/20001/Documentation/notation/simultaneous.itely#newcode188
Documentation/notation/simultaneous.itely:188: \relative {
Well, this is sort of a different issue/change now.

https://codereview.appspot.com/239250043/diff/20001/Documentation/notation/simultaneous.itely#newcode219
Documentation/notation/simultaneous.itely:219: @c Without \new Voice,
implicit voice creation does the dumbest thing.
Actually, I think that this comment is no longer accurate, so maybe the
\new Voice is now expendible.

https://codereview.appspot.com/239250043/