lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: add stencil-whiteout-outline function (issue 236480043 by address@hi


From: paulwmorris
Subject: Re: add stencil-whiteout-outline function (issue 236480043 by address@hidden)
Date: Mon, 08 Jun 2015 17:42:43 +0000


https://codereview.appspot.com/236480043/diff/60001/Documentation/changes.tely
File Documentation/changes.tely (right):

https://codereview.appspot.com/236480043/diff/60001/Documentation/changes.tely#newcode66
Documentation/changes.tely:66: now create a white background that
follows the outline of the
On 2015/06/07 20:43:54, Keith wrote:
Better to be honest
"that follows the outline of"
  -> "built from multiple displaced copies of"

how about
"built from multiple displaced copies of the glyph in order to
approximate the contours of its outline."
That indicates both what's better about the new behavior and what's
actually happening to achieve it.

https://codereview.appspot.com/236480043/diff/60001/python/convertrules.py
File python/convertrules.py (right):

https://codereview.appspot.com/236480043/diff/60001/python/convertrules.py#newcode3766
python/convertrules.py:3766: str = re.sub (r"\\whiteout(?!-box)",
r"\\whiteout-box", str)
On 2015/06/07 20:43:54, Keith wrote:
Somebody has probably defined \whiteout-custom or similar so you
should match
more narrowly   \\whiteout(?![a-z_-])

Ok, sounds good.

https://codereview.appspot.com/236480043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]