PATCH: Change PDF 'author' field to use /Author (issue 260200043 by address@hidden)

[pkx166h]

Reviewers: ,

Message:
This passes make, make check and a full make doc. However reg tests show
programming errors

for example

--snip--

 Writing ./voice-4-midi-systems.tex...
 Writing ./voice-4-midi-systems.count...
 Writing timing to voice-4-midi.profile...
+programming error: Parsed object should be dead: #<Context_def CueVoice
/home/james/lilypond-git/build/out/share/lilypond/current/ly/performer-init.ly:110:1>
+continuing, cross fingers
+programming error: Parsed object should be dead: #<Prob: Music C++:
Music((origin . #<location
out-test/voice-4-midi.ly:72:3>))((display-methods #<procedure #f
(check)>) (name . BarCheck) (types bar-check) (iterator-ctor .
#<primitive-procedure ly:bar-check-iterator::constructor>)) >
+
+continuing, cross fingers


input/regression/midi/voice-4-midi.log

--snip--

MOst (if not all of the Midi reg tests show this same error)

Description:
PATCH: Change PDF 'author' field to use /Author

Currently, the PDF author field is
filled with the composer. This is
nice fall back but in most cases
the author of the document and the
composer will be different. While
I can write pdfcomposer = "Author Name"
it appears as intended as /Author(Author Name)
but it also appears as /Composer(Author Name)
which is wrong.

Wouldn't it make sense to offer
both fields: Author and Composer
separately? A fallback if no
author is given makes sense but
it would be good to be able to
specify an author differing
from the composer.

Please review this at https://codereview.appspot.com/260200043/

Affected files (+1, -1 lines):
  M scm/framework-ps.scm


Index: scm/framework-ps.scm
diff --git a/scm/framework-ps.scm b/scm/framework-ps.scm
index  
96c584d34f384cc110dd4278ceecf8b23dfb34a3..0bcb233f5db4c73031c421dc06ed2489cdda081e  
100644
--- a/scm/framework-ps.scm
+++ b/scm/framework-ps.scm
@@ -459,7 +459,7 @@
       (if val
           (format port "/~a (~a)\n" field (metadata-encode (markup->string  
val (list header)))))))
   (display "[ " port)
-  (metadata-lookup-output 'pdfcomposer 'composer "Author")
+  (metadata-lookup-output 'pdfauthor 'composer "Author")
   (format port "/Creator (LilyPond ~a)\n" (lilypond-version))
   (metadata-lookup-output 'pdftitle 'title "Title")
   (metadata-lookup-output 'pdfsubject 'subject "Subject")