lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Issue 4591: Fix font-name overriding (issue 262330043 by address@hid


From: thomasmorley65
Subject: Re: Issue 4591: Fix font-name overriding (issue 262330043 by address@hidden)
Date: Mon, 07 Sep 2015 21:39:15 +0000


https://codereview.appspot.com/262330043/diff/20001/Documentation/snippets/new/unfretted-headword.ly
File Documentation/snippets/new/unfretted-headword.ly (right):

https://codereview.appspot.com/262330043/diff/20001/Documentation/snippets/new/unfretted-headword.ly#newcode119
Documentation/snippets/new/unfretted-headword.ly:119: \set
Score.markFormatter     =  #format-mark-box-numbers
On 2015/09/07 21:31:45, dak wrote:
On 2015/09/07 21:11:48, thomasmorley651 wrote:
> Here and below: Do we really want several spacers before "="?

Well, it's commit
commit 13da8b27aabc5d5a752d00ed1e2b99ad20f0f264
Author: David Kastrup <mailto:address@hidden>
Date:   Mon Oct 29 16:25:02 2012 +0100

     Rerun scripts/auxiliar/update-with-convert-ly.sh

for version 2.17.6 which made a hash of the indentations:
@@ -126,9 +126,9 @@ ViolinSolo = \relative c' {
    \voiceOne

    \set Score.markFormatter     =  #format-mark-box-numbers
-  \override Score.VoltaBracket #'font-name                  = #"sans"
-  \override Score.VoltaBracket #'extra-offset               = #'(0 .
1)
-  \override SpacingSpanner     #'uniform-stretching         = ##t
+  \override Score.VoltaBracket.font-name                  = #"sans"
+  \override Score.VoltaBracket.extra-offset               = #'(0 . 1)
+  \override SpacingSpanner.uniform-stretching         = ##t


    %% Measure 1
@@ -220,7 +220,7 @@ ViolinSolo = \relative c' {
        \new Staff \ViolinSolo
      >>

-    \override Score.Rest #'transparent = ##t
+    \override Score.Rest.transparent = ##t
      \set Score.defaultBarType          = "-"
    >>

Conversions like that lead to the question how much sense there is in
this sort
of block aligns in the first place.

At least in this case I'd be more happy with _one_ space before "=".
I don't like this sort of block align, but ofcourse it's only me...

https://codereview.appspot.com/262330043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]