Re: [PATCH] musicxml2ly: Avoid duplicate "tr" if both <trill-mark> and, <wavy-line> are present

[James]

Thomas,

On 13/12/15 21:48, Thomas Weber wrote:
> Another patch for musicxml2ly: In situations like this:
>
>     <trill-mark default-y='20'/>
>     <wavy-line type='start' number='1'/>
>
> this will be created:
>
>     \trill \startTrillSpan
>
> It should only be \startTrillSpan.
>
> (My changes can also be found on Github: https://github.com/th-we/lilypond.)
>
> Greets,
> Thomas Weber
This patch breaks 'make doc'

--snip--

lilypond-book.py: error: `musicxml2ly  --out=- - ' failed (0)
lilypond-book.py: error: The error log is as follows:
musicxml2ly: Reading MusicXML from Standard input ...
musicxml2ly: Converting to LilyPond expressions...
Traceback (most recent call last):
  File "/home/jlowe/lilypond-git/build/scripts/out/musicxml2ly", line
2990, in <module>
    main()
  File "/home/jlowe/lilypond-git/build/scripts/out/musicxml2ly", line
2985, in main
    voices = convert (filename, options)
  File "/home/jlowe/lilypond-git/build/scripts/out/musicxml2ly", line
2891, in convert
    (voices, staff_info) = get_all_voices (parts)
  File "/home/jlowe/lilypond-git/build/scripts/out/musicxml2ly", line
2578, in get_all_voices
    part_ly_voices[n] = musicxml_voice_to_lily_voice (v)
  File "/home/jlowe/lilypond-git/build/scripts/out/musicxml2ly", line
2402, in musicxml_voice_to_lily_voice
    ev = musicxml_articulation_to_lily_event (ch, a)
  File "/home/jlowe/lilypond-git/build/scripts/out/musicxml2ly", line
1229, in musicxml_articulation_to_lily_event
    ev = tmp_tp (mxl_event)
AttributeError: TremoloEvent instance has no __call__ method
/home/jlowe/lilypond-git/build/scripts/build/out/texi2omf --format pdf
--location
/usr/local/share/doc/lilypond/html/input/regression/musicxml/collated-files.pdf 
--version 2.19.34 out-www/collated-files.texi >
out-www/collated-files.pdf.omf
Traceback (most recent call last):
  File "/home/jlowe/lilypond-git/build/scripts/build/out/texi2omf", line
73, in <module>
    texi = open (infile).read ()
IOError: [Errno 2] No such file or directory: 'out-www/collated-files.texi'
make[4]: *** [out-www/collated-files.pdf.omf] Error 1
make[4]: Leaving directory
`/home/jlowe/lilypond-git/build/input/regression/musicxml'
make[3]: *** [WWW-1] Error 2
make[3]: Leaving directory `/home/jlowe/lilypond-git/build/input/regression'
make[2]: *** [WWW-1] Error 2
make[2]: Leaving directory `/home/jlowe/lilypond-git/build/input'
make[1]: *** [WWW-1] Error 2
make[1]: Leaving directory `/home/jlowe/lilypond-git/build'
make: *** [doc-stage-1] Error 2


--snip--

James