Re: Improve beam count handling with subdivided beams (issue 276560043 by address@hidden)

[git]

Thanks for the comments, changes uploaded.


https://codereview.appspot.com/276560043/diff/1/Documentation/snippets/new/subdividing-beams.ly
File Documentation/snippets/new/subdividing-beams.ly (right):

https://codereview.appspot.com/276560043/diff/1/Documentation/snippets/new/subdividing-beams.ly#newcode7
Documentation/snippets/new/subdividing-beams.ly:7: \version "2.19.34"
On 2015/12/22 00:48:53, Carl wrote:
> I think you should remove the header above here, because you are in
> Documentation/snippets/new

Done.

https://codereview.appspot.com/276560043/diff/1/lily/include/beaming-pattern.hh
File lily/include/beaming-pattern.hh (right):

https://codereview.appspot.com/276560043/diff/1/lily/include/beaming-pattern.hh#newcode76
lily/include/beaming-pattern.hh:76: Moment remaining_length (int idx)
const;
On 2015/12/22 00:48:53, Carl wrote:
> Why did you choose to make remaining-length public?  It seems to me
that the in
> your usage it can all be private -- that is, I don't see any use case
where some
> other beaming pattern needs to get the remaining length in this
beaming pattern.

> At least in your code, I don't see any public uses.

> But I don't feel strongly about this, and it does seem to have some
similarities
> with the other public functions.

I don't feel strong about this either. It was just the idea that it
*might* be useful from outside.

Maybe the better approach for this is to add it as a private method (as
you say I don't have any immediate public use), if someone might need it
later it can still be made public.

https://codereview.appspot.com/276560043/