Re: Improve beam count handling with subdivided beams (issue 276560043 by address@hidden)

[Urs Liska]

Am 22.12.2015 um 20:51 schrieb Carl Sorensen:
> Copy the snippet to Documentation/snippets/new.
>
> Remove the machine-generated header.
>
> Make your changes.
>
> Submit the patch.

OK, that is more or less what I did (in patch set 2).
The only thing that is left for me to update is *not* to include the
modified file in Documentation/snippets (which was modified by makelsr.py).

So basically I can simply remove the changes to that file from my patch
and upload it again, isn't it?

Urs

>
> Carl
>
> On 12/22/15 11:34 AM, "address@hidden" <address@hidden> wrote:
>
>> https://codereview.appspot.com/276560043/diff/20001/Documentation/snippets
>> /subdividing-beams.ly
>> File Documentation/snippets/subdividing-beams.ly (right):
>>
>> https://codereview.appspot.com/276560043/diff/20001/Documentation/snippets
>> /subdividing-beams.ly#newcode7
>> Documentation/snippets/subdividing-beams.ly:7: %% Note: this file works
> >from version 2.19.34
>> So unfortunately I still don't know what to do with the snippet. This is
>> the situation:
>> - The snippet already exists and is used in the NR
>> - It was not in Documentation/snippets/new before I copied it there
>>
>> So this seems to indicate that I should updated the snippet in the LSR.
>>
>> But while it will probably compile with 2.18.0 it doesn't give proper
>> result before 2.19.34, and the modified text refers to that new
>> functionality of my patch.
>>
>> So what should I do now?
>>
>> https://codereview.appspot.com/276560043/
>
> _______________________________________________
> lilypond-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/lilypond-devel