[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Store accidental styles in an alist (issue 280510043 by address@hidd
From: |
James |
Subject: |
Re: Store accidental styles in an alist (issue 280510043 by address@hidden) |
Date: |
Wed, 23 Dec 2015 13:52:36 +0000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 |
Simon,
On 22/12/15 23:36, Simon Albrecht wrote:
> On 22.12.2015 15:39, address@hidden wrote:
>> https://codereview.appspot.com/280510043/diff/20001/scm/music-functions.scm#newcode1702
>>
>> scm/music-functions.scm:1702: (define-public accidental-styles
>> The only rationale for making this a public variable is if the user is
>> expected to be able to change that variable. But in that case, the
>> settings will bleed over into the next file on the command line if the
>> variable is not declared using define-session-public instead.
>
> Thanks for the hint. New patchset uploaded.
> Yours, Simon
I'm starting to lose track.
Is this a patch set that has or has not been tested?
Are you using git-cl to upload the patch - else the Allura patch level
will not change and it will not get re-tested as I filter on any
'patch-new' and 'Started' Allura issues for testing.
James