Doc: LM 3 (Fundamental concepts) - version statements (issue 282890043 by address@hidden)

[pkx166h]

Reviewers: ,

Message:
Greg, thanks for the patch - see my comment in-line.




https://codereview.appspot.com/282890043/diff/1/Documentation/learning/fundamental.itely
File Documentation/learning/fundamental.itely (right):

https://codereview.appspot.com/282890043/diff/1/Documentation/learning/fundamental.itely#newcode2305
Documentation/learning/fundamental.itely:2305: \version @w{"@version{}"}
This breaks make doc.

I don't think you can use this syntax in an @lilypond construct. Have a
quick skim of the other examples that use this, they are in an @example
context which is completely different.

This is why we create macros (I think that is what they are called) like
'relative' and suchlike with 'addversion' being one for @lilypond
constructs.

If you can find another example in the existing documenatation that does
use this

\version @w{"@version{}"}

in an @lilypond construct, let me know (as then the issue is something
else).

Else if not then this patch is invalid.

James

Description:
Doc: LM 3 (Fundamental concepts) - version statements

Replace [addversion] with
\version @w{"@version{}"} to
avoid messy extra whitespace
in HTML output.

Please review this at https://codereview.appspot.com/282890043/

Affected files (+9, -3 lines):
  M Documentation/learning/fundamental.itely


Index: Documentation/learning/fundamental.itely
diff --git a/Documentation/learning/fundamental.itely  
b/Documentation/learning/fundamental.itely
index  
b936ca497169b425dba7f9b7063d327305c23d16..fde3d2c7fa2cdbcd5ede465af0b8e1420062f433  
100644
--- a/Documentation/learning/fundamental.itely
+++ b/Documentation/learning/fundamental.itely
@@ -2301,7 +2301,9 @@ at once.  The @code{\score} looks like this now:
 This looks a bit messy; the indentation is messed up now.  That is
 easily fixed.  Here's the complete soprano and cello template.

address@hidden,verbatim,ragged-right,addversion]
address@hidden,verbatim,ragged-right]
+\version @w{"@version{}"}
+
 sopranoMusic = \relative {
   \clef "treble"
   \key c \major
@@ -2596,7 +2598,9 @@ stacked one above the other:
 Combining all these together and adding the music
 for the three bars of the example above gives:

address@hidden,verbatim,ragged-right,addversion]
address@hidden,verbatim,ragged-right]
+\version @w{"@version{}"}
+
 global = { \key d \major \time 4/4 }
 sopranoMusic = \relative {
   \clef "treble"
@@ -2923,7 +2927,9 @@ will have a similar structure, although the number of  
voices
 may vary.  All that remains now
 is to add the music, and combine all the parts together.

address@hidden,verbatim,ragged-right,addversion]
address@hidden,verbatim,ragged-right]
+\version @w{"@version{}"}
+
 \header {
   title = "Jesu, meine Freude"
   composer = "J S Bach"