Re: Doc: LM 3 (Fundamental concepts) - version statements (issue 282890043 by address@hidden)

[pkx166h]

On 2015/12/24 15:05:10, Greg S wrote:
> On 2015/12/24 13:55:17, pkx166h wrote:
> > Greg, thanks for the patch - see my comment in-line.
> >
> >

https://codereview.appspot.com/282890043/diff/1/Documentation/learning/fundamental.itely
> > File Documentation/learning/fundamental.itely (right):
> >
> >

https://codereview.appspot.com/282890043/diff/1/Documentation/learning/fundamental.itely#newcode2305
> > Documentation/learning/fundamental.itely:2305: \version
@w{"@version{}"}
> > This breaks make doc.
> >
> > I don't think you can use this syntax in an @lilypond construct.
Have a quick
> > skim of the other examples that use this, they are in an @example
context
> which
> > is completely different.
> >
> > This is why we create macros (I think that is what they are called)
like
> > 'relative' and suchlike with 'addversion' being one for @lilypond
constructs.
> >
> > If you can find another example in the existing documenatation that
does use
> > this
> >
> > \version @w{"@version{}"}
> >
> > in an @lilypond construct, let me know (as then the issue is
something else).
> >
> > Else if not then this patch is invalid.
> >
> > James

> Sorry about that and thanks for the explanation. Happy to have a look
at
> wherever addversion is defined to see if I can get rid of the extra
whitespace,
> but I couldn't work out where to look for this. It's not a major issue
but would
> tidy up the indentation in a few places in the Learning Manual.

> Thanks,
> Greg.

Greg,

Look in $LILYPOND_GIT/python/book_snippets.py and
$LILYPOND_GIT/python/book_texinfo.py

You can find 'all' (I think) the @lilypond[...] defined 'macros' in
'book_snippets.py' and the functions (?) of each one defined in
'book_texinfo.py'

James





https://codereview.appspot.com/282890043/