[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Issue 4876/4: Enable fontname replacing in TrueType functions (issue
|
From: |
lemzwerg |
|
Subject: |
Re: Issue 4876/4: Enable fontname replacing in TrueType functions (issue 300490043 by address@hidden) |
|
Date: |
Sat, 25 Jun 2016 21:56:16 -0700 |
LGTM again, thanks!
https://codereview.appspot.com/300490043/diff/60001/lily/open-type-font.cc
File lily/open-type-font.cc (right):
https://codereview.appspot.com/300490043/diff/60001/lily/open-type-font.cc#newcode185
lily/open-type-font.cc:185: // FreeType 2.6.2+ has been fixed this
issue.)
// FreeType 2.6.2+ has this bug fixed.)
https://codereview.appspot.com/300490043/diff/60001/lily/open-type-font.cc#newcode186
lily/open-type-font.cc:186: // So we need directly parsing 'CFF' table,
in this case.
// So we need direct parsing of the 'CFF' table, in this case.
https://codereview.appspot.com/300490043/diff/60001/lily/open-type-font.cc#newcode190
lily/open-type-font.cc:190:
// See Adobe technote '5176.CFF.pdf', sections 2 and 5-7.
https://codereview.appspot.com/300490043/diff/60001/lily/open-type-font.cc#newcode217
lily/open-type-font.cc:217: + off2 - 1));
This code always gets the first name in the CFF's name index. Is this
sufficient?
https://codereview.appspot.com/300490043/