[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

first draft of css changes from John Roper (issue 313170043 by address@h

From: graham
Subject: first draft of css changes from John Roper (issue 313170043 by address@hidden)
Date: Fri, 02 Dec 2016 11:08:08 -0800

Reviewers: ,
File Documentation/css/lilypond-website.css (right):
Documentation/css/lilypond-website.css:27: @import
Please do not make multiple changes in a single commit; that makes it
harder to track what is changing.

I suggest that the first commit be purely for the navbar, but I'm
certainly open to discussing it.
Documentation/css/lilypond-website.css:64: color: #0c6be8;
This appears to make visited links /lighter/, which strikes me as a bit
odd.  Isn't the default to make visited links darker?

Hmm, according to
(which in turn cites W3C), the recommended unvisited link is #0000EE
(dark blue), while the recommended visited link is #551A8B (deep
Documentation/css/lilypond-website.css:83: margin-top: 15px;
I would feel more comfortable with em or rem here, instead of pixels.  I
do see that the original file used 7px here, but I consider that a
mistake that we don't need to continue.
Documentation/css/lilypond-website.css:122: height: 20px;
Again, I suggest that we avoid px in this age of retina displays, cell
phone browsing, etc.
Please do not add blank links.

FIXME DO NOT MERGE first draft of css changes

Please review this at

Affected files (+44, -88 lines):
  M Documentation/css/lilypond-website.css

reply via email to

[Prev in Thread] Current Thread [Next in Thread]