Re: unfoldRepeats can be restricted to certain repeat-types (issue 318890043 by address@hidden)

[thomasmorley65]

On 2016/12/03 11:34:48, dak wrote:
> mailto:address@hidden writes:

> > On 2016/12/03 11:28:24, dak wrote:
> >> mailto:address@hidden writes:
> >
> >> > On 2016/12/02 19:45:02, dak wrote:
> >> >> However, people might get surprised by
> >> >
> >> >> #(unfoldRepeats 'tremolo m)
> >> >
> >> >> not working.
> >> >
> >> > Btw, it turned out the previous unfold-repeats destructively
changed
> > the
> >> > music-argument, if called directly.
> >
> >> That's common for LilyPond functions.
> >
> >> --
> >> David Kastrup
> >
> > Ok.
> > Should I remove the call for ly:music-deep-copy?

> In the function, I think that is only consistent with what we do and
> expect elsewhere.  Of course, that might mean you have to review its
> callers to make sure they don't get tripped up by that.

> --
> David Kastrup

Will do.
Thanks for review.

https://codereview.appspot.com/318890043/