[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Web: Review GSoC page introduction (issue 315410043 by address@hidde
|
From: |
David Kastrup |
|
Subject: |
Re: Web: Review GSoC page introduction (issue 315410043 by address@hidden) |
|
Date: |
Mon, 30 Jan 2017 17:21:17 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) |
address@hidden writes:
> https://codereview.appspot.com/315410043/diff/40001/Documentation/web/community.itexi
> File Documentation/web/community.itexi (right):
>
> https://codereview.appspot.com/315410043/diff/40001/Documentation/web/community.itexi#newcode952
> Documentation/web/community.itexi:952: @subheading Adopt the SMuFL music
> font encoding standard
> On 2017/01/30 15:08:45, dak wrote:
>> Uh, that's not exactly what I would call "fixing embarrassing syntax
> errors".
>> It is a complete new paragraph.
>
>> Though it's not clear to me how this diff comes about: this appears to
> be
>> already in LilyPond proper anyway.
>
> I'm not sure what you're concretely referring to here.
> In the line the link pointed to (comparing base to patch set 3 There
> isn't anything in the diff.
>
> You will see that SMuFL project paragraph as new when you compare Patch
> set 2 with patch set 3.
Which is what I did.
> This is due to the fact that patch set 2 was uploaded before I could
> push #5037.
Ok.
> https://codereview.appspot.com/315410043/
--
David Kastrup