Re: Web: Move older news to the attic page (issue 318630043 by address@hidden)

[pkx166h]

On 2017/03/05 00:25:33, pwm wrote:
> On 2017/03/04 20:52:49, pkx166h wrote:
> >
> > I'll have a go at fixing this now.

> Thanks, I haven't had a chance to work on this yet.  Sorry I didn't
try a 'make
> doc' before uploading for review.  Since 'make website' succeeded I
thought it
> was good to go... but that's not the case.

Don't worry, it wouldn't be the first time this kind of thing has
happened :)


> One simple solution would be: Instead of renaming those two files
(which breaks
> the translations), effectively create copies of them and rename the
copies.
> Then later after the translations have been updated to use the new
files, delete
> the old copies with the old names.  (Of course building on patch set
1, one
> would copy the new versions and give them the old names...)


No I think probably the simplest thing is to just add/change the
@include references as Jean-Charles and Federico pointed out. I did a
quick and dirty test last night when I saw Jean-Charle's comment [1] and
I replaced the links in the community.texi files from the other
languages - well, all but one - that I had missed in my haste - and it
of course failed on that one, which just confirmed Jean-Charle's
diagnoses.

What I will do is take your checkin, add my bits and pieces and
re-submit the tracker and Rietveld to save you the bother - obviously
when the patch is pushed I'll make sure you get the credit in the
authorship. Then the translator-people can make sure it is OK as well.

Because of the nature of how different translations get further and
further away at different rates compared to the English version the
addition of the 'old news' link - which I think is important, is just a
simple @include at the end of the community.itexi file.

As I cannot speak all the languages that are being translated, there
will be no 'if you want to see the new news go to @ref{xxxx}' but just
the @include statement which is better than nothing. Although the
translators may disagree.

I'll ge to work on that now.

James


[1] Thanks Jean-Charles, I should have thought of that, at least now I
know why when I make some test patches on my side it's always the
Catalan translation that seems to cause problems (i.e. it isn't, it's
just that that is the first one in the list of translated languages), so
now I know this it will help me in the future to diagnose problems more
quickly.



https://codereview.appspot.com/318630043/