Re: Additions in event-listener.ly (issue 152600043 by address@hidden)

[graham]

On 2017/03/22 10:24:21, dak wrote:
> ly/event-listener.ly:69: (eq? 0 (ly:moment-grace-numerator moment))
> Why this change for the worse?  Numbers need to be compared with eqv?
rather
> than eq? and I don't see that anything was wrong with zero? here since
> ly:moment-grace-numerator certainly cannot return a non-number.

I suspect that this arose from "git rebase".  You changed this in 2013
in 1c869295b643d256a99de90f67d32b442f6f0586; if the original patch was
made from a branch that happened before that, it would of course have
the previous (eq? 0 ...).

[incidently, the (eq? 0 ... was part of the first version I wrote, in
2011.]


https://codereview.appspot.com/152600043/