Re: Allow 'staff-padding to work with MeasureCounter (issue 312580043 by address@hidden)

[david . nalesnik]

On 2017/03/29 22:00:12, pkx166h wrote:
> >
> > Sorry, I mean the *first* snippet.  (The count that begins with two
could be
> > pushed further from the staff possibly.)

> Yes that is probably a good idea (if you could add something that
would normally
> collide - would a slur/tie *over* one of the group of notes work? - to
give such
> an 'excuse' to use the padding?

There won't be any collisions -- the numbers will automatically avoid
them.

{
  \startMeasureCount
  c''4( c''''-\accent-\staccato-\marcato g'' d'''')
  \stopMeasureCount
}

The only good excuse to use staff-padding would be in an example such as
in the snippet I provided with the patch: getting all numbers at the
same level where different content in one measure would ordinarily push
the number higher than the number in another measure.  But as Simon
points out, the usage of staff-padding for this purpose is already well
documented.  There's no need for a new snippet, and I see no convenient
way to slip staff-padding into one of the existing snippets without it
being an "unjustified" change.


> Also we should have a changes.tely entry as well - use your original
snippet as
> the example there to use the work you have already done.


This is a simple bugfix of something that should have worked since the
MeasureCounter was introduced in 2.17.something.  As such, I don't think
a Changes entry is warranted.

I would propose simply that I fix that bug only, nothing else -- no
extra snippet, no changes to the existing snippets (which are already
dense enough with information).  So I am inclined to upload a patch just
with the scm/define-grobs.scm alterations.



https://codereview.appspot.com/312580043/