[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Create engravers for merging rests (issue 321930043 by address@hidde

From: thomasmorley65
Subject: Re: Create engravers for merging rests (issue 321930043 by address@hidden)
Date: Thu, 18 May 2017 13:54:41 -0700
File scm/merge-rests-engraver.scm (right):
scm/merge-rests-engraver.scm:10: (define (rest-length rest)
This definition is unused later and wouldn't work because of here
undefined 'rest-a'.
Maybe change it to something iterating over a list, comparing their
elements looking at their 'duration-log for Rests and 'measure-count for
And use it for checking equal Rests/MMRs.
scm/merge-rests-engraver.scm:23: (define-public merge-rests-engraver
Two general questions:
Is it possible to merge both engravers or is there a use case to have
them separated?
What do you think about introducing a property to switch rest-merging
Could be a grob-property, both support rest-interface. Or probably a
context-property because the engraver(s) are in Staff.
scm/merge-rests-engraver.scm:72: `((start-translation-timestep .
,(lambda (trans)
The order:
feels irritating and does not correspondend to the time they are called.
Any reason I for it, I'm not aware?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]