[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fixes to better note lengths, now supports meter changes

From: Christopher Heckman
Subject: Re: Fixes to better note lengths, now supports meter changes (issue 325800043 by address@hidden)
Date: Sat, 27 May 2017 23:10:31 -0500

On Sat, May 27, 2017 at 4:00 AM,  <address@hidden> wrote:
> Reviewers: ,
> Message:
> This fails a basic 'make' when applied to current master.

It works for me.

> Also Christopher, if and when you submit a new patch, can you clean up
> the whitespace errors that are also reported ('git apply' squelches
> some, but I can see that you are using tabs in the diff on Rietveld and
> this will cause comments by other devs). Also see:

Okay, I'll take a look.

--- Chris

> regards
> Description:
> Fixes to better note lengths, now supports meter changes
> (1) Note lengths currently are fractions like 61/120. If the numerator
> can be changed by 1 to get a better fraction, it is done. Quarter
> notes are also replaced with eighths/sixteenths if appropriate.
> For example: a duration of 4*61/120 is changed to 4*1/2 and then
> to 8. (2) Current version of midi2ly does not support meter changes.
> Patch does.
> Resolves: #5119
> Please review this at
> Affected files (+87, -50 lines):
>   M scripts/

Christopher Carl Heckman
Honors Faculty
33° 25' 7'' N, 111° 55' 55'' W
ECA 212
School of Mathematical & Statistical Sciences
Arizona State University (T1N R4E Sect22 NW1/4)
Tempe, AZ 85287 - 1804
United States of America
North America
Planet Earth
Solar System
Gould Belt
Local Bubble
Local Fluff
Milky Way Galaxy, Orion Arm
Local Group
Virgo Supercluster
Pisces-Cetus Supercluster Complex

reply via email to

[Prev in Thread] Current Thread [Next in Thread]