[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Issue #5246: Make empty scores abort engraving process (issue 332470
From: |
David Kastrup |
Subject: |
Re: Issue #5246: Make empty scores abort engraving process (issue 332470043 by address@hidden) |
Date: |
Fri, 22 Dec 2017 15:42:39 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) |
Dan Eble <address@hidden> writes:
> On Dec 21, 2017, at 23:06, address@hidden wrote:
>>
>> @@ -110,8 +110,7 @@ LY_DEFINE (ly_interpret_music_expression,
>> "ly:interpret-music-expression",
>>
>> if (!iter->ok ())
>> {
>> - warning (_ ("no music found in score"));
>> - /* todo: should throw exception. */
>> + error (_ ("no music found in score"));
>> return SCM_BOOL_F;
>> }
>
> Looking at this in isolation, I wonder whether “no music found” is the
> only reason that iter might not be OK; in other words, was the message
> appropriate before you arrived?
\new Voice { }
_is_ arguably music. The other error message before is actually just
nonsensical since LY_ASSERT_SMOB already catches the respective
condition. I think we should just let this one complete properly (and
thus also get an image/PDF) though with a warning.
I actually thought I did change this at one time. At any rate, a
_fatal_ error at least seems silly. There is no reason not to continue
here.
--
David Kastrup