Re: Charles Winston's GSoC code: Chord Semantics (issue 337870043 by address@hidden)

[pkx166h]

Hello Charles,

Thanks for your patch however, this fails make check.

It fails on a number of different reg tests but all with the same basic
error.

Example:

~~~
/home/james/lilypond-git/input/regression/chord-names-lower-case-minor.ly'
warning: cannot find property type-check for `chord-semantics'
(music-type?).  perhaps a typing error?

Writing timing to 77/lily-34d19eca.profile...
programming error: Parsed object should be dead: #<Lily_lexer (#<module
2b102b5ce7c0>) >
continuing, cross fingers
~~~

and

~~~
/home/james/lilypond-git/input/regression/fret-diagrams-fret-label.ly'
warning: cannot find property type-check for `chord-semantics'
(music-type?).  perhaps a typing error?

Writing timing to 97/lily-43513982.profile...
programming error: Parsed object should be dead: #<Lily_lexer (#<module
2b102b5c8ba0>) >
continuing, cross fingers
~~~

and

~~~
/home/james/lilypond-git/input/regression/chord-semantics-bass.ly'
warning: type check for `chord-step' failed; value `bass' must be of
type `pair'
warning: cannot find property type-check for `chord-semantics'
(music-type?).  perhaps a typing error?

Writing timing to d3/lily-efd6a06c.profile...
programming error: Parsed object should be dead: #<Lily_lexer (#<module
2b102b5cc860>) >
continuing, cross fingers
~~~

etc.

https://codereview.appspot.com/337870043/